Ensure we fetch tags before building a module #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modules, notably masterfiles, rely on git to determine version numbers.
|
Fire it up |
|
Trying to fetch tags, as others have before me: |
nickanderson
approved these changes
May 19, 2023
olehermanse
added a commit
to cfengine/masterfiles
that referenced
this pull request
May 19, 2023
There were a couple of problems related to version numbers inside the masterfiles build module. For this time, we have to do a more custom / hardcoded approach. See: cfengine/build-index#421 cfengine/build-index#420 aceb20a Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules, notably masterfiles, rely on git to determine version numbers.