Reworked the internal of this library. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbina
force-pushed
the
issue_220
branch
2 times, most recently
from
14e4d52
to
1269182
Compare
Implemented some helper functions Partially implemented some of the easier functions from here servo/rust-smallvec#220 (comment) Implemented `PartialEq` for SmallSet Added tests for `replace`. nitpick from Intellij Rust SmallSet is now a wrapper over enum of SmallVec and HashSet Insertion now moves to a heap allocated HashSet when capacity. Fixed compilation error from previous commit Might want to merge this two later. Cleared now changes to stack. Implemented drain Moved tests and updated them. Updated tests. Fixed set equality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am trying to learn more advanced concepts in Rust and I took to reworking the internals of this library.
In particular, I have done:
Attempting to implement some of the functions requested here Adding SmallSet servo/rust-smallvec#220 .
I have already implemented some of the easy ones.
Make
SmallVeca wrapper over an enum ofSmallVecandHashSet. The size of this union should be about the same and it wont cause O(n) operating when its spilling into the heap.Implement some traits like
PartialEqandDebug.What do you think? Any feedback/review is appreciated!