Feature/generic oauth provider updates #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to refactor the client into separate clients: OAuth2, OAuth2JWT, OpenId and Salesforce
Add the type to the properties to validate
The Salesforce related components will be separated out
Remove all the interfaces that have been moved out and make sure they are exported Do not export the clients as they are internal and should be used with the cache
Generate certificates in the tests via the pem pacakage
This is largely based upon the Salesforce system tests
mwoodffdc
requested review from
sfrycertinia,
pwrightcertinia,
dfruddffdc and
rcorfieldffdc
|
@sfryffdc This should address the comment in #24 (review). I had a thought that it would be good to have the type of client in the environment too and split out the OAuth2/OAuth2JWT/OpenID/Salesforce related stuff, hence this PR is a bit larger than I intended, but more extensible. @rcorfieldffdc It should also address your comments of reducing the risk of parameter injection. |
sfrycertinia
previously approved these changes
Mar 11, 2019
sfrycertinia
previously approved these changes
Mar 12, 2019
mwoodffdc
force-pushed
the
feature/generic-oauth-provider-updates
branch
from
aaf73bb
to
cd82f2e
Compare
pwrightcertinia
approved these changes
Mar 12, 2019
sfrycertinia
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment) and client specific (OpenIdOptions) properties.Only parts of the specifications required for the Salesforce Client are implemented