Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Required Python Version #152

Merged
merged 4 commits into from Oct 27, 2021
Merged

Added Required Python Version #152

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12ffeee
Added Required Python Version
Nirzak Apr 21, 2021
94f0347
Updated required python version
Nirzak Apr 21, 2021
42f0b3d
Removed Classifiers for unsupported python versions
Nirzak Oct 8, 2021
a616491
Updated
Nirzak Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Expand Up @@ -48,15 +48,14 @@
include_package_data=True,
zip_safe=False,
license='MPL-2.0',
python_requires=">=3.5",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be preferable to introduce this in declarative config. i.e.:

# setup.cfg
[options]
python_requires = >=3.5

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to do setup-py-upgrade in another pr I think?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, perhaps. My preference is to introduce changes in the preferred location rather than to cling to old conventions, but I also see the value in keeping it all consistent and to move everything at once.

classifiers=[
'Development Status :: 5 - Production/Stable',
'Intended Audience :: Developers',
'License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)',
'Natural Language :: English',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
Nirzak marked this conversation as resolved.
Show resolved Hide resolved
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
Expand Down