Ignore the new W504 error from flake8 to get the tests passing #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very confused, it doesn't appear to be ignoring either of the errors it says it's ignoring? |
|
Not sure why this isn't working. Could try flipping the order of the ignores to see if that helps, but honestly it's only yelling about a few places so it might just be worth it to fix those. |
|
Switched order doesn't seem to affect it. Maybe the E501s can be fixed, but unfortunately I don't think the W504s can. W504 complains about a binary operator before a linebreak, there's also a warning about binary operators after a linebreak, so you need to ignore at least one of them! |
|
This seems relevant: tholo/pytest-flake8#8 (comment) |
ohemorange
reviewed
Oct 25, 2018
ohemorange
reviewed
Oct 25, 2018
Co-Authored-By: alex <alex.gaynor@gmail.com>
Co-Authored-By: alex <alex.gaynor@gmail.com>
|
Nice catch! (Also the "suggest changes" UI is slick!) |
ohemorange
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.