-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade all JavaScript dependencies #1156
Conversation
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See https://nextjs.org/docs/messages/invalid-new-link-with-extra-anchor Signed-off-by: Richard Wall <richard.wall@jetstack.io>
The configuration we had seems to be incomplete, so I removed it which should switch us to the default image loading mechanism. See https://nextjs.org/docs/messages/next-image-missing-loader Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See https://nextjs.org/docs/messages/next-image-upgrade-to-13 Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See hashicorp/next-mdx-remote#307 (comment) Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See iamvishnusankar/next-sitemap@a4e18ba Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See https://nextjs.org/docs/api-reference/next/image#unoptimized Signed-off-by: Richard Wall <richard.wall@jetstack.io>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the remarks below, I ran npm shrinkwrap
which resulted in the renaming of package-lock.json → npm-shrinkwrap.json
This seems to be best practice for npm applications (versus libraries) but I may have misunderstood:
I think npm-shrinkwrap.json is only useful when you are talking about libraries:
|
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Agreed. I've reverted that change. PTAL |
Thank you for upgrading! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Preview: https://deploy-preview-1156--cert-manager-website.netlify.app/
I've upgraded to nextjs 13 and also upgraded all the other dependencies in
package.json
.This required some (mostly machine generated) changes to the code.
See comments below for more context.