Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all JavaScript dependencies #1156

Merged
merged 13 commits into from
Jan 17, 2023
Merged

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jan 13, 2023

Preview: https://deploy-preview-1156--cert-manager-website.netlify.app/

I've upgraded to nextjs 13 and also upgraded all the other dependencies in package.json.
This required some (mostly machine generated) changes to the code.

See comments below for more context.

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
The configuration we had seems to be incomplete, so I removed it which should
switch us to the default image loading mechanism. See

https://nextjs.org/docs/messages/next-image-missing-loader

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See hashicorp/next-mdx-remote#307 (comment)

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
See iamvishnusankar/next-sitemap@a4e18ba

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2023
@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 514e8c5
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/63c6715e8342e200083ecd13
😎 Deploy Preview https://deploy-preview-1156--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member Author

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the remarks below, I ran npm shrinkwrap which resulted in the renaming of package-lock.json → npm-shrinkwrap.json

This seems to be best practice for npm applications (versus libraries) but I may have misunderstood:

components/Button.jsx Show resolved Hide resolved
components/Image.jsx Show resolved Hide resolved
components/docs/VersionSelect.jsx Show resolved Hide resolved
lib/remark-plugins/heading-ids/index.js Show resolved Hide resolved
next.config.js Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@inteon
Copy link
Member

inteon commented Jan 13, 2023

In addition to the remarks below, I ran npm shrinkwrap which resulted in the renaming of package-lock.json → npm-shrinkwrap.json

This seems to be best practice for npm applications (versus libraries) but I may have misunderstood:

I think npm-shrinkwrap.json is only useful when you are talking about libraries:
https://medium.com/@hossam.hilal0/package-json-vs-package-lock-json-vs-npm-shrinkwrap-json-33fcddc1521a

Thus:
If you are not publishing your package to npm, the choice between these two files
is of little consequence. You may wish to use package-lock.json because it is the default
and its name is clearer to npm beginners; alternatively, you may wish to use npm-shrinkwrap.json
for backwards compatibility with npm 2-4 if it is difficult for you to ensure everyone
on your development team is on npm 5+. (Note that npm 5 was released on 25th May 2017;
backwards compatibility will become less and less important the further we get from that
date, as most people will eventually upgrade.)

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Copy link
Member Author

wallrj commented Jan 17, 2023

I think npm-shrinkwrap.json is only useful when you are talking about libraries:
https://medium.com/@hossam.hilal0/package-json-vs-package-lock-json-vs-npm-shrinkwrap-json-33fcddc1521a

Agreed. I've reverted that change.

PTAL

@wallrj wallrj requested a review from inteon January 17, 2023 09:59
@inteon
Copy link
Member

inteon commented Jan 17, 2023

Thank you for upgrading!
/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 33561d4 into cert-manager:master Jan 17, 2023
@wallrj wallrj deleted the upgrade-1 branch January 17, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants