Bump the all group with 7 updates #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
jetstack-bot
added
dco-signoff: yes
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jetstack-bot
added
the
size/L
|
/approve |
jetstack-bot
added
lgtm
Bumps the all group with 7 updates: | Package | From | To | | --- | --- | --- | | [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) | `2.14.0` | `2.15.0` | | [github.com/onsi/gomega](https://github.com/onsi/gomega) | `1.30.0` | `1.31.1` | | [k8s.io/api](https://github.com/kubernetes/api) | `0.29.0` | `0.29.1` | | [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) | `0.29.0` | `0.29.1` | | [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.29.0` | `0.29.1` | | [k8s.io/klog/v2](https://github.com/kubernetes/klog) | `2.120.0` | `2.120.1` | | [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) | `0.16.3` | `0.17.0` | Updates `github.com/onsi/ginkgo/v2` from 2.14.0 to 2.15.0 - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.14.0...v2.15.0) Updates `github.com/onsi/gomega` from 1.30.0 to 1.31.1 - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.30.0...v1.31.1) Updates `k8s.io/api` from 0.29.0 to 0.29.1 - [Commits](kubernetes/api@v0.29.0...v0.29.1) Updates `k8s.io/cli-runtime` from 0.29.0 to 0.29.1 - [Commits](kubernetes/cli-runtime@v0.29.0...v0.29.1) Updates `k8s.io/component-base` from 0.29.0 to 0.29.1 - [Commits](kubernetes/component-base@v0.29.0...v0.29.1) Updates `k8s.io/klog/v2` from 2.120.0 to 2.120.1 - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.120.0...v2.120.1) Updates `sigs.k8s.io/controller-runtime` from 0.16.3 to 0.17.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.16.3...v0.17.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: k8s.io/component-base dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/all-9fdf43d1c1
branch
from
a4f213d
to
5744613
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
reviewed
Feb 6, 2024
| @@ -1273,18 +1273,26 @@ func Test_Reconcile(t *testing.T) { | |||
| }, | |||
| } | |||
|
|
|||
| deepCopyArray := func(arr []client.Object) []client.Object { | |||
There was a problem hiding this comment.
I had to add this function to fix a race condition caused by kubernetes-sigs/controller-runtime#1306.
inteon
reviewed
Feb 6, 2024
| @@ -577,16 +584,17 @@ func (b *bundle) needsUpdate(ctx context.Context, log logr.Logger, obj *metav1.P | |||
| } | |||
|
|
|||
| { | |||
| key := "" | |||
| targetFieldNames := []string{"data"} | |||
| targetType := obj.TypeMeta.Kind | |||
There was a problem hiding this comment.
We shouldn't rely on the TypeMeta.Kind value being there as pointed out in kubernetes-sigs/controller-runtime#2633.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the all group with 7 updates:
2.14.02.15.01.30.01.31.10.29.00.29.10.29.00.29.10.29.00.29.12.120.02.120.10.16.30.17.0Updates
github.com/onsi/ginkgo/v2from 2.14.0 to 2.15.0Release notes
Sourced from github.com/onsi/ginkgo/v2's releases.
Changelog
Sourced from github.com/onsi/ginkgo/v2's changelog.
Commits
7fa0190v2.15.0c245d09emit output of failed go tool cover invocation so users can try to debug thin...dca77c8fix outline when using nodot inginkgo v296e915cinclude cancellation reason when cancelling spec context4fcd0b3Bump to go 1.20732abbcclarify that last owner label wins8f3bd70JUnit reports now interpret Label(owner:X) and set owner to X.dbaf18fDocument areas where GinkgoT() behaves differently from testing.T6f67a14bugfix(docs): use Unsetenv instead of Clearenv (#1337)Updates
github.com/onsi/gomegafrom 1.30.0 to 1.31.1Release notes
Sourced from github.com/onsi/gomega's releases.
Changelog
Sourced from github.com/onsi/gomega's changelog.
Commits
762b171v1.31.126661b8tidy up go.sumbde8f7abump dependencies24e958dShow how to import the format sub packagead1a367Update test in case keeping msg is desirede0dd999Inverted arguments order of FailureMessage of BeComparableToMatcherba8bba2v1.31.0121c37fAsync assertions include context cancellation cause if presentdee1e3cBump minimum go version49005fedocs: fix typo in example usage "occured" -> "occurred"Updates
k8s.io/apifrom 0.29.0 to 0.29.1Commits
c1d5818Update dependencies to v0.29.1 taga48c0a4Merge pull request #122429 from MadhavJivrajani/tools-bump-129656e18f.*: bump golang.org/x/tools to v0.16.1Updates
k8s.io/cli-runtimefrom 0.29.0 to 0.29.1Commits
0bd7b29Update dependencies to v0.29.1 tagb1485ddMerge pull request #122429 from MadhavJivrajani/tools-bump-1299cab777.*: bump golang.org/x/tools to v0.16.1Updates
k8s.io/component-basefrom 0.29.0 to 0.29.1Commits
2065849Update dependencies to v0.29.1 tagaca7dbbMerge pull request #122429 from MadhavJivrajani/tools-bump-1295587b24.*: bump golang.org/x/tools to v0.16.1Updates
k8s.io/klog/v2from 2.120.0 to 2.120.1Release notes
Sourced from k8s.io/klog/v2's releases.
Commits
007e661textlogger: allow caller to override stack unwindingUpdates
sigs.k8s.io/controller-runtimefrom 0.16.3 to 0.17.0Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
... (truncated)
Commits
11e5a5eMerge pull request #2651 from kubernetes-sigs/dependabot/go_modules/github.co...66939d4Merge pull request #2655 from joelanford/bump-apidiff672d678bump go-apidiff to v0.8.2d5f5430Update generated codea23bdc8🌱 Bump github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.09e6e3b1Merge pull request #2650 from alvaroaleman/bump-jsonpatchea529dd🐛 Don't truncate large int64s in MergePatch48d9a7bMerge pull request #2647 from fxierh/fix-client-commentsf29ed4eElaborate in which cases the client reads from a cache7679253Merge pull request #2649 from sbueringer/pr-bump-ctDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions