WIP: Benchmark tool #46
Conversation
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/benchmark/command.go
Outdated
There was a problem hiding this comment.
go.mod
Outdated
There was a problem hiding this comment.
There was a problem hiding this comment.
-
https://pkg.go.dev/k8s.io/apimachinery/pkg/apis/meta/v1#ListMeta
// remainingItemCount is the number of subsequent items in the list which are not included in this
// list response. If the list request contained label or field selectors, then the number of
// remaining items is unknown and the field will be left unset and omitted during serialization.
// If the list is complete (either because it is not chunking or because this is the last chunk),
// then there are no more remaining items and this field will be left unset and omitted during
// serialization.
// Servers older than v1.15 do not set this field.
// The intended use of the remainingItemCount is estimating the size of a collection. Clients
// should not rely on the remainingItemCount to be set or to be exact.
| sync.RWMutex | ||
| options | ||
| record |
There was a problem hiding this comment.
Explain the embedded record hack, or find a cleaner alternative.
| } | ||
| if l.RemainingItemCount != nil { | ||
| o.CertificateCount = *l.RemainingItemCount + 1 | ||
| } |
There was a problem hiding this comment.
Explain the remainingItemCount hack or find an alternative.
| ../setup.sh | ||
| cmctl x benchmark > experiment.${experiment_id}.json | ||
| jq -s -r 'include "module-cm"; recordsToCSV' < experiment.${experiment_id}.json > experiment.${experiment_id}.csv | ||
| ``` |
There was a problem hiding this comment.
Consider a --output-format=csv flag.
There was a problem hiding this comment.
Document the experiments.
Add hypothesis and conclusion to each.
There was a problem hiding this comment.
Annotate the diagrams highlighting points of interest.
pkg/benchmark/testdata/module-cm.jq
Outdated
pkg/benchmark/testdata/setup.sh
Outdated
There was a problem hiding this comment.
Consider adding these steps to a setup option of the command.
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
…ables Signed-off-by: Richard Wall <richard.wall@venafi.com>
…ible Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
…pages Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Signed-off-by: Richard Wall <richard.wall@venafi.com>
Experiment 2024-04-07-5