Remove unnecessary Azure workload identity setting: DisableInstanceDiscovery: true

[wallrj]

In #5452 (comment) @weisdd wrote:

• Earlier, you asked whether "DisableInstanceDiscovery" should be set to true or false. - I think it's better to not use DisableInstanceDiscovery: true (like in the code now), better to stick to defaults. I haven't seen it being disabled in other projects.

So I've removed it.

The field is documented as follows: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity#ClientAssertionCredentialOptions

// DisableInstanceDiscovery should be set true only by applications authenticating in disconnected clouds, or
// private clouds such as Azure Stack. It determines whether the credential requests Microsoft Entra instance metadata
// from https://login.microsoft.com before authenticating. Setting this to true will skip this request, making
// the application responsible for ensuring the configured authority is valid and trustworthy.
DisableInstanceDiscovery bool

Which further convinces me that this should not be set to true by default.
Perhaps it should be configurable in some circumstances though?
And if so we can tackle that in another PR.

/kind cleanup

NONE

[wallrj]

@inteon PTAL. Let me know if you can find a way to override that endpoint rather than disabling it.

[inteon]

Looks good @wallrj!
I think the workaround you found is very acceptable.
Based on the feedback we got, it seems like a good idea to remove this DisableInstanceDiscovery: true option.
/approve
/lgtm

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wallrj]

/cherrypick release-1.14

[jetstack-bot]

@wallrj: new pull request created: #6681

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.