Bump k8s.io dependencies #5097

lucacome · 2022-05-04T16:59:08Z

This PR:

updates Kubernetes libraries to v0.23.4 -> v0.24.2
updates controller-runtime v0.11.1 -> v0.11.2
updates controller-tools v0.7.0 -> v0.9.2
updates helm library v3.8.1 -> v3.9.0 (needed as [only this Helm is compatible with kube v0.24)
pins a bunch of open telemetry modules to older versions (as they seem to get bumped due to some transitive dependency of the newer helm libary, but clash with Kubernetes libraries- we'll be able to unpin once Use of outdated OpenTelemetry Go package kubernetes/kubernetes#106536 gets done)
changes informerResyncPeriod in unit test framework to not be less than the minimum resync period (see Slack thread) and bumps the wait time for test cache initial sync. The tests were failing on this - I am not exactly sure why as I don't see related changes in kube v0.24, but I assume it's because the wait time was less than the actual cache sync time.

Updates Kubernetes libraries to `v0.24.2`.

Signed-off-by: Luca Comellini luca.com@gmail.com

jetstack-bot · 2022-05-04T16:59:17Z

Hi @lucacome. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lucacome · 2022-05-04T17:01:53Z

/assign @JoshVanL

SgtCoDFish · 2022-05-05T10:19:35Z

Thank you for raising this 😁

/ok-to-test

lucacome · 2022-05-05T13:06:07Z

I think this is needed first helm/helm#10928

SgtCoDFish · 2022-05-05T13:21:28Z

Fair enough! There's no major rush, we don't have a release for at least a month 👍

irbekrm · 2022-06-30T09:01:53Z

/milestone v1.9

irbekrm · 2022-06-30T10:48:15Z

Hi @lucacome thanks again for working on this!

Do you think you will have time to rebase and update this PR? We're thinking to release the last 1.9 pre-release today/tomorrow and would be good to get this work in as well!
You might also need to run ./hack/update-bazel.sh to get the Bazel files updated

lucacome · 2022-06-30T14:54:51Z

Hi @irbekrm I can rebase/update as soon as #5251 is merged

irbekrm · 2022-06-30T15:11:33Z

you should be able to update with ./hack/update-bazel.sh there shouldn't be a need for another command to update the Bazel files

lucacome · 2022-06-30T22:25:30Z

/retest

lucacome · 2022-06-30T22:32:20Z

 (22:28:59) ERROR: /bazel-scratch/.cache/bazel/_bazel_root/9a4ffe169a47b22ecc4990eba5f8384d/external/sh_helm_helm_v3/pkg/kube/BUILD.bazel:3:11: GoCompilePkg external/sh_helm_helm_v3/pkg/kube/kube.a failed: (Exit 1): builder failed: error executing command bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/sh_helm_helm_v3/pkg/kube/client.go -src external/sh_helm_helm_v3/pkg/kube/config.go ... (remaining 104 argument(s) skipped)
Use --sandbox_debug to see verbose messages from the sandbox
external/sh_helm_helm_v3/pkg/kube/client.go:92:12: cannot use cmdutil.NewFactory(getter) (value of type "k8s.io/kubectl/pkg/cmd/util".Factory) as type Factory in struct literal:
	"k8s.io/kubectl/pkg/cmd/util".Factory does not implement Factory (wrong type for Validator method)
		have Validator(validationDirective string, verifier *"k8s.io/cli-runtime/pkg/resource".QueryParamVerifier) (validation.Schema, error)
		want Validator(validate bool) (validation.Schema, error)

There seems to be at least one error related to helm. I'm not really sure how that can be fixed @irbekrm feel free to push to this PR if you have any ideas.

Signed-off-by: irbekrm <irbekrm@gmail.com>

As the later version has a breaking change (bumps github.com/emicklei/go-restful -> github.com/emicklei/go-restful/v3) Signed-off-by: irbekrm <irbekrm@gmail.com>

irbekrm · 2022-07-01T18:19:48Z

Building now succeeds, but he certificate signing request and gateway unit tests are still failing.

irbekrm · 2022-07-01T18:21:35Z

go.mod

+	github.com/containerd/containerd => github.com/containerd/containerd v1.5.10
 	github.com/miekg/dns v1.1.41 => github.com/miekg/dns v1.1.34
+	go.opentelemetry.io/contrib => go.opentelemetry.io/contrib v0.20.0
+	go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc => go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.20.0
+	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp => go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.20.0
+	go.opentelemetry.io/otel => go.opentelemetry.io/otel v0.20.0
+	go.opentelemetry.io/otel/exporters/otlp => go.opentelemetry.io/otel/exporters/otlp v0.20.0
+	go.opentelemetry.io/otel/metric => go.opentelemetry.io/otel/metric v0.20.0
+	go.opentelemetry.io/otel/oteltest => go.opentelemetry.io/otel/oteltest v0.20.0
+	go.opentelemetry.io/otel/sdk => go.opentelemetry.io/otel/sdk v0.20.0
+	go.opentelemetry.io/otel/sdk/export/metric => go.opentelemetry.io/otel/sdk/export/metric v0.20.0
+	go.opentelemetry.io/otel/sdk/metric => go.opentelemetry.io/otel/sdk/metric v0.20.0
+	go.opentelemetry.io/otel/trace => go.opentelemetry.io/otel/trace v0.20.0
+	go.opentelemetry.io/proto/otlp => go.opentelemetry.io/proto/otlp v0.7.0


These are needed till kubernetes/kubernetes#106536 gets fixed

As minimum resync period in client-go is 1s. Also makes sure that the tests don't sleep for 'too long'. Signed-off-by: irbekrm <irbekrm@gmail.com>

Signed-off-by: irbekrm <irbekrm@gmail.com>

irbekrm · 2022-07-04T08:25:14Z

/test pull-cert-manager-e2e-feature-gates-disabled
/test pull-cert-manager-e2e-issuers-venafi-cloud
/test pull-cert-manager-e2e-v1-20
/test pull-cert-manager-e2e-v1-21
/test pull-cert-manager-e2e-v1-22
/test pull-cert-manager-e2e-v1-23
/test pull-cert-manager-issuers-venafi-tpp

irbekrm · 2022-07-04T10:27:07Z

This should now be ready for another lgtm (I cannot do that as I've now also contributed)

SgtCoDFish · 2022-07-04T10:34:53Z

pkg/controller/test/context_builder.go

-const informerResyncPeriod = time.Millisecond * 10
+const informerResyncPeriod = time.Second


for context: https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1656920615091279

SgtCoDFish · 2022-07-04T10:38:00Z

make/tools.mk

-KUBEBUILDER_TOOLS_linux_amd64_SHA256SUM=25daf3c5d7e8b63ea933e11cd6ca157868d71a12885aba97d1e7e1a15510713e
-KUBEBUILDER_TOOLS_darwin_amd64_SHA256SUM=bb27efb1d2ee43749475293408fc80b923324ab876e5da54e58594bbe2969c42
+KUBEBUILDER_TOOLS_linux_amd64_SHA256SUM=6d9f0a6ab0119c5060799b4b8cbd0a030562da70b7ad4125c218eaf028c6cc28
+KUBEBUILDER_TOOLS_darwin_amd64_SHA256SUM=3367987e2b40dadb5081a92a59d82664bee923eeeea77017ec88daf735e26cae


note: just spotted that they've added darwin-arm64 support so we can update to use that and remove our rosetta-based workaround. I'll raise a separate PR for that, don't think it needs to go in this one!

SgtCoDFish

/lgtm
/approve
/hold

Adding a hold in case anyone else wants to take a look. This seems totally reasonable but I've not dug deeply into the version upgrades or anything!

Thank you to everyone who's been involved in this, looks like it was quite a bit of work!

jakexks

/unhold

jetstack-bot · 2022-07-04T13:44:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, lucacome, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SgtCoDFish,jakexks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jetstack-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 4, 2022

lucacome changed the title ~~Bump k8s.io dependencies to v0.24.0~~ Bump k8s.io dependencies May 4, 2022

jetstack-bot assigned JoshVanL May 4, 2022

jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2022

lucacome force-pushed the bump-k8s-deps branch from 0063483 to 75713d0 Compare May 5, 2022 12:10

lucacome force-pushed the bump-k8s-deps branch from 75713d0 to 3828eb2 Compare May 24, 2022 17:44

jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2022

lucacome force-pushed the bump-k8s-deps branch from 3828eb2 to 9670df9 Compare June 6, 2022 16:38

jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2022

lucacome force-pushed the bump-k8s-deps branch from 9670df9 to 7b84ef5 Compare June 6, 2022 16:56

lucacome force-pushed the bump-k8s-deps branch from 7b84ef5 to a2c4ec9 Compare June 15, 2022 21:27

jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2022

jetstack-bot added this to the v1.9 milestone Jun 30, 2022

lucacome force-pushed the bump-k8s-deps branch from a2c4ec9 to 1ecde8c Compare June 30, 2022 15:41

jetstack-bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 30, 2022

irbekrm assigned irbekrm and unassigned JoshVanL Jul 1, 2022

irbekrm added 3 commits July 1, 2022 19:16

Bump Helm dependency

cb86bdf

Signed-off-by: irbekrm <irbekrm@gmail.com>

Bump versions of kubebuilder assets and kubectl

1c48a73

Signed-off-by: irbekrm <irbekrm@gmail.com>

Downgrade kube-openapi

a93e028

As the later version has a breaking change (bumps github.com/emicklei/go-restful -> github.com/emicklei/go-restful/v3) Signed-off-by: irbekrm <irbekrm@gmail.com>

irbekrm reviewed Jul 1, 2022

View reviewed changes

irbekrm added 2 commits July 4, 2022 08:52

Bump informerResyncPeriod

bcc691d

As minimum resync period in client-go is 1s. Also makes sure that the tests don't sleep for 'too long'. Signed-off-by: irbekrm <irbekrm@gmail.com>

Updates LICENSES

5903c34

Signed-off-by: irbekrm <irbekrm@gmail.com>

cert-manager deleted a comment from jetstack-bot Jul 4, 2022

jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 4, 2022

cert-manager deleted a comment from jetstack-bot Jul 4, 2022

SgtCoDFish reviewed Jul 4, 2022

View reviewed changes

SgtCoDFish approved these changes Jul 4, 2022

View reviewed changes

jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022

jetstack-bot assigned SgtCoDFish Jul 4, 2022

jetstack-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2022

SgtCoDFish mentioned this pull request Jul 4, 2022

Kubebuilder Assets darwin/arm64 #5264

Merged

jakexks approved these changes Jul 4, 2022

View reviewed changes

jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022

jetstack-bot merged commit 5a4e765 into cert-manager:master Jul 4, 2022

lucacome deleted the bump-k8s-deps branch July 7, 2022 21:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump k8s.io dependencies #5097

Bump k8s.io dependencies #5097

lucacome commented May 4, 2022 •

edited by irbekrm

jetstack-bot commented May 4, 2022

lucacome commented May 4, 2022

SgtCoDFish commented May 5, 2022

lucacome commented May 5, 2022

SgtCoDFish commented May 5, 2022

irbekrm commented Jun 30, 2022

irbekrm commented Jun 30, 2022

lucacome commented Jun 30, 2022

irbekrm commented Jun 30, 2022 •

edited

lucacome commented Jun 30, 2022

lucacome commented Jun 30, 2022

irbekrm commented Jul 1, 2022

irbekrm Jul 1, 2022

irbekrm commented Jul 4, 2022

irbekrm commented Jul 4, 2022

SgtCoDFish Jul 4, 2022

SgtCoDFish Jul 4, 2022

SgtCoDFish left a comment

jakexks left a comment

jetstack-bot commented Jul 4, 2022

		const informerResyncPeriod = time.Millisecond * 10
		const informerResyncPeriod = time.Second

Bump k8s.io dependencies #5097

Bump k8s.io dependencies #5097

Conversation

lucacome commented May 4, 2022 • edited by irbekrm

jetstack-bot commented May 4, 2022

lucacome commented May 4, 2022

SgtCoDFish commented May 5, 2022

lucacome commented May 5, 2022

SgtCoDFish commented May 5, 2022

irbekrm commented Jun 30, 2022

irbekrm commented Jun 30, 2022

lucacome commented Jun 30, 2022

irbekrm commented Jun 30, 2022 • edited

lucacome commented Jun 30, 2022

lucacome commented Jun 30, 2022

irbekrm commented Jul 1, 2022

irbekrm Jul 1, 2022

Choose a reason for hiding this comment

irbekrm commented Jul 4, 2022

irbekrm commented Jul 4, 2022

SgtCoDFish Jul 4, 2022

Choose a reason for hiding this comment

SgtCoDFish Jul 4, 2022

Choose a reason for hiding this comment

SgtCoDFish left a comment

Choose a reason for hiding this comment

jakexks left a comment

Choose a reason for hiding this comment

jetstack-bot commented Jul 4, 2022

lucacome commented May 4, 2022 •

edited by irbekrm

irbekrm commented Jun 30, 2022 •

edited