Update logr dependency #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
solonish
commented
Feb 11, 2022
solonish
commented
- Upgraded logr version to v1.2.2, upgraded sigs.k8s.io/controller-runtime to v0.11.0 - controller-runtime is broken by github.com/go-logr/logr v1.0.0 kubernetes-sigs/controller-runtime#1607, upgraded cert-manager version to v1.7.1
- Changed NullLogger to Discard - NullLogger is deprecated https://pkg.go.dev/github.com/go-logr/logr@v0.4.0/testing#NullLogger
- Changed TestLogger to NewTestLogger - https://github.com/go-logr/logr/releases/tag/v1.1.0
- Updated to golang:1.17 - install controller-gen failed: sf.IsExported undefined kubernetes-sigs/controller-tools#643
…ime to v0.11.0 - kubernetes-sigs/controller-runtime#1607, upgraded cert-manager version to v1.7.1 Signed-off-by: Nishanth Solomon <solonish@amazon.com>
…go.dev/github.com/go-logr/logr@v0.4.0/testing#NullLogger Signed-off-by: Nishanth Solomon <solonish@amazon.com>
…/releases/tag/v1.1.0 Signed-off-by: Nishanth Solomon <solonish@amazon.com>
Signed-off-by: Nishanth Solomon <solonish@amazon.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: solonish The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added a commit
that referenced
this pull request
Feb 15, 2022
Update logr dependency (#122)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.