This repository has been archived by the owner on May 22, 2024. It is now read-only.
Clarify Node Version Support #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
requested review from
dkasper-was-taken,
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
mjhenkes
approved these changes
Mar 19, 2020
StephenEsser
approved these changes
Mar 19, 2020
tbiethman
approved these changes
Mar 19, 2020
benbcai
reviewed
Mar 19, 2020
package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "description": "Utilities to help when developing terra modules.", | |||
| "main": "lib/index.js", | |||
| "engines": { | |||
| "node": ">=8.9.2" | |||
| "node": ">=8.9.2 <12" | |||
There was a problem hiding this comment.
Should we make this >= 8.10.0 <12 due to this issue cerner/eslint-config-terra#42
There was a problem hiding this comment.
..... maybe??
BenBoersma
approved these changes
Mar 19, 2020
benbcai
approved these changes
Mar 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
terra-toolkit depends on wdio 4 which depends on a version of fibers that is incompatible with node 12 +