Moved postcss config to its own file. Updated webpack dependencies #888
Conversation
| @@ -0,0 +1,3 @@ | |||
| const config = require('./packages/terra-site/postcss.config'); | |||
|
|
|||
| module.exports = config; | |||
There was a problem hiding this comment.
this file doesn't do anything right now, but it will be used by storybook once its added and will ensure storybook uses the same postcss config as terra-site.
| 'last 2 versions', | ||
| 'last 2 android versions', | ||
| 'last 2 and_chr versions', | ||
| 'iOS >= 8', |
There was a problem hiding this comment.
should this be bumped to 10? @mjhenkes
There was a problem hiding this comment.
Yes, our currently minimum supported version is 10.2
| "webpack-dev-server": "^2.4.5" | ||
| "sass-loader": "^6.0.6", | ||
| "style-loader": "^0.19.0", | ||
| "webpack": "^3.6.0", |
There was a problem hiding this comment.
I'm not sure if we will be able to bump webpack versions until terra-toolkit's webpack version is bumped. When I made changes in toolkit for nightwatch, I ran across webpack chunk issues in consumer when trying to run nightwatch tests.
Do the nightwatch tests run without error?
There was a problem hiding this comment.
We'll see after travisCI runs. I'd say +1 on this provided travisCI passes.
| "webpack-dev-server": "^2.4.5" | ||
| "sass-loader": "^6.0.6", | ||
| "style-loader": "^0.19.0", | ||
| "webpack": "^3.6.0", |
There was a problem hiding this comment.
It appears there are nightwatch tests failures after updating webpack. We'll want to get this resolved, feel free to reach out to @emilyrohrbough and @ryanthemanuel as they are the most familiar with the nightwatch / webpack / toolkit setup.
There was a problem hiding this comment.
This PR should address those failures https://github.com/cerner/terra-toolkit/pull/14/files
There was a problem hiding this comment.
Gonna clear out travis CI's node_modules cache and rerun the build. This should pick up the toolkit v2.1.0 release
There was a problem hiding this comment.
oh, i explicitly updated to it
There was a problem hiding this comment.
Might need to update the version in terra-site as well: https://github.com/cerner/terra-core/blob/master/packages/terra-site/package.json#L109-L110
There was a problem hiding this comment.
i don't think it actually uses that version
There was a problem hiding this comment.
Ok once tests pass, lets get this merged down.
|
Hurray! |
Summary
This is a prep change to make storybook integration easier and simpler. I moved postcss config to its own file and removed it from webpack. This cleans up the webpack build and makes it slightly easier to understand.
I also noticed webpack errors during complication and it seems it was a version issue. I took the liberty to update all the dependencies as well which I noticed resolves a nasty issue we ran into with terra-consumer where CSS files are being concatenated in an indeterministic-order.. This makes using CSS custom properties more predictable when expecting
:root{}declarations to override previously imported components props.