Postcss refactor and Webpack Update #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 29, 2017 11:13
|
Closing pull reuqest, realized I didn't create this branch off master :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a prep change to make storybook integration easier and simpler. I moved postcss config to its own file and removed it from webpack. This cleans up the webpack build and makes it slightly easier to understand.
I also noticed webpack errors and it seems it was a version issue. I took the liberty to update all the dependencies as well which I noticed resolves a nasty issue we ran into with terra-consumer where CSS files are being concatenated in an indeterministic-order.
Thanks for contributing to Terra.
@cerner/terra