Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Tag select fixes #4024

Closed
wants to merge 11 commits into from
Closed

Tag select fixes #4024

wants to merge 11 commits into from

Conversation

PK106552
Copy link
Contributor

@PK106552 PK106552 commented Feb 7, 2024

Summary

What was changed:

  1. Added error message and instruction text to validate invalid example.
  2. Screen reader will read as combobox for Terra tag select.
  3. When text is typed in search bar first ESC should close the dropdown and then pressing ESC again should clear out the text.
  4. Added placeholder text to tag select aria-label.

Why it was changed:

  1. There was no error message for invalid example.
  2. Terra Combobox component should have a role of combobox and it should be announced by the screen reader.
  3. When there is some user typed text in search bar and dropdown of available options is open, first ESC should close the dropdown and then pressing ESC again should clear out the text.
  4. Placeholder text was not included to tag select aria-label.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9715


Thank you for contributing to Terra.
@cerner/terra

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -331,6 +331,8 @@ class MenuUtil {
});
}

static isMac () { return navigator.userAgent.indexOf('Mac') !== -1 && navigator.userAgent.indexOf('Win') === -1 };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the second condition needed? I would assume that if the OS is Mac then it's automatically not windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second condition is not need, removed it, thanks

Copy link

stale bot commented May 13, 2024

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label May 13, 2024
@stale stale bot closed this May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants