GQL API for getStorageAt and getLogs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-norden
approved these changes
Jul 4, 2021
| for index, receiptBytes := range receiptsBytes { | ||
| receiptCID := receiptCIDs[index] | ||
| receipt := new(types.Receipt) | ||
| if err := rlp.DecodeBytes(receiptBytes, receipt); err != nil { |
There was a problem hiding this comment.
For compatibility with EIP-2718 enveloped transactions and receipts (EIP-2930 access list and EIP-1559 dynamic fee) we can no longer use RLP encoding/decoding, we instead need to use the MarshalBinary and UnmarshalBinary methods for receipts and transactions.
Related issue and more info here: #78 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #68. Supersedes #69