rlp.EncodeToBytes => tx.MarshalBinary

[i-norden]

For #245

While Thomas was testing geth vs ipld-eth-server output a discrepancy was identified with the "eth_getRawTransaction*" endpoints:

geth:
{
    "jsonrpc": "2.0",
    "id": 1,
    "result": "0x02f86e8204bc42843b9aca00843b9aca0e82520894e22ad83a0de117ba0d03d5e94eb4e0d80a69c62a82117780c080a00fdcce5c89cf7cdece6aafdeb53ddd419708245bfb82c40429b95b903c3af487a00a82d20e108d6e4d9880911ec70bd50f123a091926fc949a9c8ff6189769bdde"
}
ipld-eth-server:
{
    "jsonrpc": "2.0",
    "id": 1,
    "result": "0xb87102f86e8204bc42843b9aca00843b9aca0e82520894e22ad83a0de117ba0d03d5e94eb4e0d80a69c62a82117780c080a00fdcce5c89cf7cdece6aafdeb53ddd419708245bfb82c40429b95b903c3af487a00a82d20e108d6e4d9880911ec70bd50f123a091926fc949a9c8ff6189769bdde"
}

I suspect this is the issue, if it isn't- it is still an issue.

[i-norden]

rlp.EncodeToBytes was also being used for the expected results we compare to in the unit and integration tests, so the results matched and the issue was not detected there.

[AFDudley]

Why did Ian write this patch instead of Thomas?

[telackey]

When I found the bug this afternoon, I discussed it with Ian, and he had an idea on the fix before I had looked in to the cause.

Incidentally, this does look like a fix:

test/test_tx.py::test_get_raw_transaction PASSED
test/test_tx.py::test_get_raw_transaction_by_block PASSED                                                                                                                                                  

From: https://git.vdb.to/cerc-io/system-tests