Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPC api and backend to support the EIP-2930 and EIP-1559 updates to header and transaction types #78

Closed
i-norden opened this issue Jul 1, 2021 · 1 comment · Fixed by #83

Comments

@i-norden
Copy link
Collaborator

i-norden commented Jul 1, 2021

When BaseFee is present we need to include it in the header returned by the RPC endpoints

e.g. at
https://github.com/vulcanize/ipld-eth-server/blob/42f066772bec4b38d77e2fb095bf3af4eccaf881/pkg/eth/backend_utils.go#L38

And we need to be able to return all three types of transactions from the RPC endpoints: legacy, access list, and dynamic fee

e.g. at
https://github.com/vulcanize/ipld-eth-server/blob/42f066772bec4b38d77e2fb095bf3af4eccaf881/pkg/eth/backend_utils.go#L137

@i-norden
Copy link
Collaborator Author

i-norden commented Jul 4, 2021

Note: Receipt and Transaction now need to to use MarshalBinary and UnmarshalBinary methods instead of EncodeRLP and DecodeRLP (or rlp.EncodeToBytes/rlp.DecodeBytes) for consensus encoding/decoding to/from binary format.

Until ethereum/go-ethereum#22806 is merged we need to use https://github.com/vulcanize/go-ethereum/releases/tag/v1.10.4-ir-0.0.1 for Receipt MarshalBinary and UnmarshalBinary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant