Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump observability to a version that enforces numeric params #1214

Merged
merged 2 commits into from
May 17, 2024

Conversation

gvelez17
Copy link
Contributor

Cas ANchor workers not outputting metrics - #INFRA-39

Description

the json parsed parameters for intervals were being passed thru as strings

@gvelez17 gvelez17 marked this pull request as ready for review May 17, 2024 20:03
@gvelez17
Copy link
Contributor Author

the actual changes are in ceramicnetwork/observability#32 already merged

@gvelez17 gvelez17 requested a review from smrz2001 May 17, 2024 20:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (9e952f0) to head (c91e557).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1214   +/-   ##
========================================
  Coverage    79.46%   79.46%           
========================================
  Files           47       47           
  Lines         1899     1899           
  Branches       301      301           
========================================
  Hits          1509     1509           
  Misses         390      390           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvelez17 gvelez17 merged commit 0a2d4f3 into develop May 17, 2024
6 checks passed
@gvelez17 gvelez17 deleted the chore/bump-observability-1.5.6 branch May 17, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants