Adding support for multiple DCs #416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wflanagan
reviewed
Oct 30, 2019
| @@ -86,6 +86,28 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe "#configure" do | |||
There was a problem hiding this comment.
@ryakh This looks fine to me. I'm wondering if you can create a small test that pushes some data back and forth in both of these cases, so we all can be sure it works?
ilanusse
reviewed
Oct 31, 2019
lib/cequel/metal/keyspace.rb
Outdated
| def extract_cassandra_options(configuration) | ||
| configuration[:cassandra_options] | ||
| end | ||
|
|
||
| def extract_datacenter(configuration) | ||
| configuration.fetch(:datacenter, nil) |
There was a problem hiding this comment.
I'd prefer just configuration[:datacenter]
ryakh
force-pushed
the
add-datacenter-support
branch
from
56ab0ec
to
5107227
Compare
Cequel is trying to work around the potential that ActiveSupport's Module.delegate monkey patch exists. It reset's Forwardable's delegate method to use ActiveSupport's delegate method definition. But with Ruby 3 no longer handling mixed positional and keyword args, this monkey patch no longer works. We've updated to handle the kwargs.
AM-493: Monkey patch Util::Forwardable to work with Ruby 3 kwargs
It makes it *highly* non-obvious how instrumentation is actually happening / being set up. Instead move it into a `Cequel::Metal::DatadogInstrumentation.instrument!` method, which we can call in the midst of setting up all other datadog instrumentation.
As we attempt to migrate to Datadog, we need Cassandra instrumentation to match what we currently use in New Relic. Follow along with the built in New Relic instrumentation, but using Datadog's APIs. Caveat: The existing New Relic instrumentation attempts to patch the client code automatically based on if attempting to load the new relic library "works". We don't want to do this with Datadog. It makes the instrumentation "appear out of nowhere" (source: over an hour of me trying to figure out where New Relic instrumentation came from). Instead, do the patching inside of a `Cequel::Metal::DatadogInstrumentation.instrument!` method, which we can call during an initializer along with all other Datadog instrumentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving #262
Adding support for multiple DC's with a
DCAwareRoundRobinload-balancing policy.