test/dashboard: fix segfault when importing dm.xmlsec.binding #25139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python-saml depends on dm.xmlsec.binding which is a python binding of xmlsec C library. but without -DXMLSEC_NO_SIZE_T the compiled dm.xmlsec.binding segfaults when `import dm.xmlsec.binding`. see SAML-Toolkits/python-saml#30 and 4teamwork/ftw.saml2auth#3 . in long term, we might want to switch to python-saml, see http://tracker.ceph.com/issues/37081 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
this should fix "make check" failures like see also #25053. |
Yes, but once we have the appropriate python-saml/pysaml2 installation method for CentOS (and similar ones), |
alfonsomthd
approved these changes
Nov 19, 2018
p-se
approved these changes
Nov 19, 2018
b-ranto
pushed a commit
to b-ranto/ceph
that referenced
this pull request
Nov 28, 2018
Duplicate error messages currently appear if the task wrapper service is used. It calls 'notifyTask' on a failed task, this would be fine if we didn't have the API interceptor, which watches all API requests and triggers 'notifyTask' itself if an error appears. Fixes issue ceph#25139 Signed-off-by: Stephan Müller <smueller@suse.com> (cherry picked from commit 70d47a5) Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-saml depends on dm.xmlsec.binding which is a python binding of
xmlsec C library. but without -DXMLSEC_NO_SIZE_T the compiled
dm.xmlsec.binding segfaults when
import dm.xmlsec.binding. seeSAML-Toolkits/python-saml#30 and
4teamwork/ftw.saml2auth#3 .
in long term, we might want to switch to python-pysaml2, see
http://tracker.ceph.com/issues/37081
Signed-off-by: Kefu Chai kchai@redhat.com