Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: bump k8s.io/klog/v2 from 2.10.0 to 2.20.0 #2525

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 20, 2021

Bumps k8s.io/klog/v2 from 2.10.0 to 2.20.0.

Release notes

Sourced from k8s.io/klog/v2's releases.

Prepare klog release for Kubernetes v1.23

Changes are here : kubernetes/klog@v2.10.0...v2.20.0

since we moved to logr v1.0.0, there are incompatible changes:

- klogger.Enabled: changed from func() bool to func(int) bool
- klogger.Info: changed from func(string, ...interface{}) to func(int, string, ...interface{})
- klogger.V: removed
- klogger.WithCallDepth: changed from func(int) github.com/go-logr/logr.Logger to func(int) github.com/go-logr/logr.LogSink
- klogger.WithName: changed from func(string) github.com/go-logr/logr.Logger to func(string) github.com/go-logr/logr.LogSink
- klogger.WithValues: changed from func(...interface{}) github.com/go-logr/logr.Logger to func(...interface{}) github.com/go-logr/logr.LogSink

83653a6deebf Update to newest versions of golang 1.17.x d648c2e42d30 fix file-based filtering symbolization 8ee3d652c96b export ClearLogger 4171f3c1be1b Switching to logr tag v1.0.0 9ab3c2b56cb2 add serathius as approvers of klog

Commits
  • f8e668d Merge pull request #260 from dims/update-to-newest-versions-of-golang-1.17
  • 83653a6 Update to newest versions of golang 1.17.x
  • d648c2e fix file-based filtering symbolization
  • e1f317b Merge pull request #250 from yuzhiquan/add-serathius-approver
  • 74b1b2a Merge pull request #257 from pohly/clear-logger
  • 8ee3d65 export ClearLogger
  • 4171f3c Switching to logr tag v1.0.0
  • 9ab3c2b add serathius as approvers of klog
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the rebase update the version of an external component label Sep 20, 2021
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 21, 2021

level=error msg="Running error: bodyclose: failed prerequisites: [errors in package: [/go/src/github.com/ceph/ceph-csi/internal/controller/controller.go:23:15: could not import sigs.k8s.io/controller-runtime/pkg/client/config (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/client/config/config.go:29:7: could not import sigs.k8s.io/controller-runtime/pkg/internal/log (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/internal/log/log.go:22:2: could not import sigs.k8s.io/controller-runtime/pkg/log (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:82:31: cannot use (NullLogger literal) (value of type NullLogger) as logr.Logger value in argument to NewDelegatingLogger))) /go/src/github.com/ceph/ceph-csi/internal/controller/controller.go:24:2: could not import sigs.k8s.io/controller-runtime/pkg/manager (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:38:2: could not import sigs.k8s.io/controller-runtime/pkg/cache (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/cache/cache.go:30:2: could not import sigs.k8s.io/controller-runtime/pkg/cache/internal (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/cache/internal/cache_reader.go:33:2: could not import sigs.k8s.io/controller-runtime/pkg/client (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/client/client.go:35:2: could not import sigs.k8s.io/controller-runtime/pkg/log (/go/src/github.com/ceph/ceph-csi/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:82:31: cannot use (NullLogger literal) (value of type NullLogger) as logr.Logger value in argument to NewDelegatingLogger)))))]]"

Need manual rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/klog/v2-2.20.0 branch from 7489e2c to 2bff80a Compare September 21, 2021 08:33
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 21, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@nixpanic
Copy link
Member

@dependabot rebase

Maybe other vendor updates make this work now?

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/klog/v2-2.20.0 branch from 2bff80a to 2173585 Compare September 28, 2021 10:27
@nixpanic
Copy link
Member

This probably depends on kubernetes-sigs/controller-runtime#1593

@nixpanic nixpanic added the dependency/k8s depends on Kubernetes features label Sep 28, 2021
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.10.0 to 2.20.0.
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.10.0...v2.20.0)

---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/klog/v2-2.20.0 branch from 2173585 to 0cc285f Compare October 5, 2021 11:44
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 25, 2021

Superseded by #2590.

@dependabot dependabot bot closed this Oct 25, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/klog/v2-2.20.0 branch October 25, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency/k8s depends on Kubernetes features rebase update the version of an external component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants