Upgrade Mermaid to v9.3.0 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that the size of ProseCode component javascript was >1MB. This is due to the mermaid package being so large. Upgrading this library comes with a 31% size reduction out of the box - mermaid-js/mermaid#3825 Test plan: - Check the mermaid diagrams are rendering as expected - Check there are no visual regressions around the mermaid diagrams - Test on Chrome, Edge, Firefox and Safari
Ray2126
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the size of ProseCode component javascript was >1MB. This is due to the mermaid package being so large. Upgrading this library comes with a 31% size reduction out of the box - mermaid-js/mermaid#3825
Test plan: