AsyncTransport: eagerly process queue on stop() #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, you don't want to just rely on the `atexit` handler, but manually shut down the `AsyncTransport` in your application and be sure all the logs are flushed from it. Calling `.flush(); .stop()` is not ideal, because `flush` could block for an unnecessarily long time. This PR: * sets the stop event in `_Worker.stop`, so the queue begins processing immediately * removes `_Worker._export_pending_data`, which became redundant, and just uses `stop` as the atexit handler * Exposes a public `stop` method on `AsyncTransport` * Driveby: clarify `grace_period` and `wait_period` units in docstring
gjoseph92
requested review from
c24t,
reyang,
songy23 and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, you don't want to just rely on the
atexithandler, but manually shut down theAsyncTransportin your application and be sure all the logs are flushed from it. Calling.flush(); .stop()is not ideal, becauseflushcould block for an unnecessarily long time. This PR:_Worker.stop, so the queue begins processing immediately_Worker._export_pending_data, which became redundant, and just usesstopas the atexit handlerstopmethod onAsyncTransportgrace_periodandwait_periodunits in docstring