Added aiohttp integration #1031

maciejmoskala · 2021-05-13T09:55:43Z

Aiohttp integration to track async requests. Library way build based on opencensus-ext-requests and it was tested on real life environment.

google-cla · 2021-05-13T09:55:47Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

maciejmoskala · 2021-05-13T09:58:04Z

@googlebot I signed it!

google-cla · 2021-05-13T09:58:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

maciejmoskala · 2021-05-13T10:01:13Z

@googlebot I fixed it.

google-cla · 2021-05-13T10:01:17Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

maciejmoskala · 2021-06-01T06:42:27Z

@aabmass @hectorhdzg @lzchen @songy23 What I should do to make this PR approved? Is there any flow I need to follow?

maciejmoskala · 2021-08-16T14:25:15Z

@lzchen What should I do to make this PR to be added to project and to have package released?

lzchen · 2021-08-16T17:18:38Z

contrib/opencensus-ext-aiohttp/CHANGELOG.md

+- Added attributes following specs listed [here](https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/HTTP.md#attributes)
+  ([#746](https://github.com/census-instrumentation/opencensus-python/pull/746))
+- Support exporter changes in `opencensus>=0.7.0`
+- Initial version


Please consolidate changes into one bullet point and hyperlink this PR.

lzchen · 2021-08-16T17:19:57Z

contrib/opencensus-ext-aiohttp/README.rst

@@ -0,0 +1,53 @@
+OpenCensus requests Integration


Suggested change

OpenCensus requests Integration

OpenCensus aiohttp client Integration

lzchen · 2021-08-16T17:20:21Z

contrib/opencensus-ext-aiohttp/README.rst

+
+::
+
+    pip install opencensus-ext-requests


Suggested change

pip install opencensus-ext-requests

pip install opencensus-ext-aiohttp

aabmass

Thanks for the PR, and sorry for the slow response 😄 Since this won't work on 2.7 and potentially 3.{4,6}, you'll have to update tox.ini similar to what I did here https://github.com/census-instrumentation/opencensus-python/pull/1056/files#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449

aabmass · 2021-08-16T17:16:45Z

contrib/opencensus-ext-aiohttp/README.rst

+
+You can enable aiohttp integration by specifying ``'aiohttp'`` to ``trace_integrations``.
+
+It's possible to configure a list of URL you don't want traced, anf it's configurable by giving an array of


aabmass · 2021-08-16T17:17:41Z

contrib/opencensus-ext-aiohttp/opencensus/ext/aiohttp/__init__.py

@@ -0,0 +1,17 @@
+# Copyright 2017, OpenCensus Authors


Can you update copyright years to 2021?

aabmass · 2021-08-16T17:18:59Z

contrib/opencensus-ext-aiohttp/opencensus/ext/aiohttp/trace.py

+    excludelist_hostnames = execution_context.get_opencensus_attr(
+        "excludelist_hostnames"
+    )
+    url_host_with_port = url.host + (f":{url.port}" if url.port else "")


Since f-strings are only since python3.6, this is probably breaking tests (we support back to 2.7)

aabmass · 2021-08-16T17:20:57Z

contrib/opencensus-ext-aiohttp/setup.py

+        "License :: OSI Approved :: Apache Software License",
+        "Programming Language :: Python",
+        "Programming Language :: Python :: 3",
+        "Programming Language :: Python :: 3.6",


Does aiohttp not support 3.5 and 3.4?

aabmass · 2021-08-16T17:23:11Z

contrib/opencensus-ext-aiohttp/setup.py

+        "Programming Language :: Python :: 3.8",
+        "Programming Language :: Python :: 3.9",
+    ],
+    description="OpenCensus Requests Integration",


typo "requests"

aabmass · 2021-08-16T17:23:33Z

contrib/opencensus-ext-aiohttp/tests/test_aiohttp_trace.py

+    async def test_wrap_session_request(self):
+        mock_tracer = MockTracer()
+        patch_tracer = mock.patch(
+            "opencensus.ext.requests.trace.execution_context." "get_opencensus_tracer",


typo "requests" in a few places in here

lzchen · 2021-08-16T17:26:51Z

contrib/opencensus-ext-aiohttp/README.rst

+.. |pypi| image:: https://badge.fury.io/py/opencensus-ext-aiohttp.svg
+   :target: https://pypi.org/project/opencensus-ext-aiohttp/
+
+OpenCensus can trace asynchronous HTTP requests made with the `aiohttp package`_. The request URL,


Please mention somewhere explicitly that only Python versions 3.6+ are supported.

lzchen · 2021-08-16T17:33:08Z

@maciejmoskala

Thanks for the contribution and sorry for the long wait in reviewing. In terms of integration contributions, we expect contributors to maintain this part of the codebase in the future. OpenCensus maintainers will assist when needed by the responsibility for maintaining, reviewing issues/PRs and releasing related to this integration falls on the contributor. Is this alright with you?

polys · 2021-11-29T11:29:13Z

Can I please ask if this is abandoned?

lzchen · 2021-11-30T18:54:08Z

@maciejmoskala
Are you still working on this PR?

maciejmoskala requested review from aabmass, hectorhdzg, lzchen, songy23 and a team as code owners May 13, 2021 09:55

google-cla bot added the cla: no label May 13, 2021

Added aiohttp integration

c439511

maciejmoskala force-pushed the adding-aiohttp-ext branch from 3b3df7c to c439511 Compare May 13, 2021 14:10

google-cla bot added cla: yes and removed cla: no labels May 13, 2021

lzchen force-pushed the master branch from 9bb688d to 29fd633 Compare May 13, 2021 22:11

Merge branch 'master' into adding-aiohttp-ext

fc14b8b

Merge branch 'master' into adding-aiohttp-ext

2388b27

lzchen reviewed Aug 16, 2021

View reviewed changes

aabmass requested changes Aug 16, 2021

View reviewed changes

lzchen reviewed Aug 16, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added aiohttp integration #1031

Added aiohttp integration #1031

maciejmoskala commented May 13, 2021

google-cla bot commented May 13, 2021

maciejmoskala commented May 13, 2021

google-cla bot commented May 13, 2021

maciejmoskala commented May 13, 2021

google-cla bot commented May 13, 2021

maciejmoskala commented Jun 1, 2021

maciejmoskala commented Aug 16, 2021

lzchen Aug 16, 2021

lzchen Aug 16, 2021

lzchen Aug 16, 2021

aabmass left a comment •

edited

aabmass Aug 16, 2021

aabmass Aug 16, 2021

aabmass Aug 16, 2021

aabmass Aug 16, 2021

aabmass Aug 16, 2021

aabmass Aug 16, 2021

lzchen Aug 16, 2021

lzchen commented Aug 16, 2021

polys commented Nov 29, 2021

lzchen commented Nov 30, 2021

	OpenCensus requests Integration
	OpenCensus aiohttp client Integration

	pip install opencensus-ext-requests
	pip install opencensus-ext-aiohttp


		You can enable aiohttp integration by specifying ``'aiohttp'`` to ``trace_integrations``.

		It's possible to configure a list of URL you don't want traced, anf it's configurable by giving an array of

Added aiohttp integration #1031

Are you sure you want to change the base?

Added aiohttp integration #1031

Conversation

maciejmoskala commented May 13, 2021

google-cla bot commented May 13, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

maciejmoskala commented May 13, 2021

google-cla bot commented May 13, 2021

maciejmoskala commented May 13, 2021

google-cla bot commented May 13, 2021

maciejmoskala commented Jun 1, 2021

maciejmoskala commented Aug 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aabmass left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lzchen commented Aug 16, 2021

polys commented Nov 29, 2021

lzchen commented Nov 30, 2021

aabmass left a comment •

edited