This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Make the duration longer in order to export the stats #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Jun 5, 2018
| @@ -74,7 +74,7 @@ func main() { | |||
| // Wait for a duration longer than reporting duration to ensure the stats | |||
| // library reports the collected data. | |||
| fmt.Println("Wait longer than the reporting duration...") | |||
| time.Sleep(2 * time.Second) | |||
| time.Sleep(10 * time.Second) | |||
There was a problem hiding this comment.
Can we instead make the reporting period shorter? It is not nice for a user to wait for 10 seconds on an example.
There was a problem hiding this comment.
It sounds to be a better way. I would have a try.
There was a problem hiding this comment.
SGTM. We can re-store to the previous reporting period once #773 is resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the duration longer in order to export the stats by printing it out. The previous branch is contaminated that I delete it directly.