Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

fix: Hackney leaks {ssl_closed, _} back to oc_reporter #159

Conversation

bipthelin
Copy link

@bipthelin bipthelin commented Sep 11, 2019

Tracked here: benoitc/hackney#464
this became apparent when using oc_google_reporter which uses Hackney

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bipthelin
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@bipthelin
Copy link
Author

@googlebot I fixed it.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@kbip
Copy link

kbip commented Sep 11, 2019

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bipthelin
Copy link
Author

This PR does not fully fix the problem. Closing for now

@bipthelin bipthelin closed this Sep 17, 2019
@astutecat
Copy link

@bipthelin We've got this happening frequently enough on a system that I'm working on that it's crashing the VM. Did you come across a workaround to this at all?

@bipthelin
Copy link
Author

@bipthelin We've got this happening frequently enough on a system that I'm working on that it's crashing the VM. Did you come across a workaround to this at all?

This commit fixed it for us: opencensus-beam/oc_google_reporter@bb578a5

It seems that if you don't close hackney either explicitly with hackney:close(Ref) or implicitly by reading the body the pool will eventually get exhausted.

@astutecat
Copy link

thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants