-
Notifications
You must be signed in to change notification settings - Fork 40
fix: Hackney leaks {ssl_closed, _} back to oc_reporter #159
fix: Hackney leaks {ssl_closed, _} back to oc_reporter #159
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR does not fully fix the problem. Closing for now |
@bipthelin We've got this happening frequently enough on a system that I'm working on that it's crashing the VM. Did you come across a workaround to this at all? |
This commit fixed it for us: opencensus-beam/oc_google_reporter@bb578a5 It seems that if you don't close hackney either explicitly with |
thanks for this! |
Tracked here: benoitc/hackney#464
this became apparent when using
oc_google_reporter
which usesHackney