Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades the react native webview package to fix SSL issue #5774

Merged
merged 5 commits into from Nov 10, 2020

Conversation

medhakothari
Copy link
Contributor

Description

Upgrades the react native webview package, because it includes this PR & this PR, which fix the SSL error in the below issue.

Tested

Repro'd issue and tested solution on a Samsung Galaxy S10 emulator.

Related issues

Backwards compatibility

Yes

updates react native webview package
Copy link
Contributor

@annakaz annakaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Double checked this fixes it on a pixel too. Thanks Medha

@medhakothari medhakothari added the automerge Have PR merge automatically when checks pass label Nov 10, 2020
@mergify mergify bot merged commit 9fd0693 into master Nov 10, 2020
@mergify mergify bot deleted the medhak1-patch-1 branch November 10, 2020 02:52
@Lss-Ankit
Copy link

Hi @medhak1 @jeanregisser I have verified this issue latest test flight build v1.5.5 (34) and Android play store internal build v1.5.5 (1004294323) and found the following:

  • “Please provide a valid Celo address” error message is displayed when the user taps on the Continue button after pasting the cUSD address.
  • User able to proceed to next page after removing space between two word fromaddress.

Also, we have filed a bug yesterday for the same:
Ticket ID : #5922

Devices Used: Samsung Galaxy A5 (7.0), iPhone SE (13.5.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WALLET] Android Users SBAT see the Simplex Widget Webview without seeing an SSL Error
4 participants