Soloseng/L2-lockedGold #10986
Closed
Soloseng/L2-lockedGold #10986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soloseng/L2-lockedGold
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
pahor167
reviewed
May 23, 2024
| @@ -131,7 +133,7 @@ contract LockedGold is | |||
| /** | |||
| * @notice Locks gold to be used for voting. | |||
| */ | |||
| function lock() external payable nonReentrant { | |||
| function lock() external payable nonReentrant onlyL1 { | |||
There was a problem hiding this comment.
we need to keep this function in L2 otherwise governance voting will not work
|
I believe this PR is not necessary since we want to keep these functions even in L2 |
|
This should have been closed when the issue was closed. Closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated LockedGold to reflect proposed L2 changes
Tested
unit tested
Related issues
Backwards compatibility
This PR deprecates the following functions post L2 migration, and will revert when called: