fix #1927: upgrade btcd #1990
Merged
fix #1927: upgrade btcd #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
requested review from
gastonponti and
piersy
and removed request for
a team
|
Coverage from tests in coverage: 47.9% of statements across all listed packagescoverage: 52.9% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 56.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 56.4% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 69b72d95f7 |
Codecov ReportBase: 54.82% // Head: 54.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1990 +/- ##
==========================================
- Coverage 54.82% 54.81% -0.02%
==========================================
Files 688 695 +7
Lines 92542 93258 +716
==========================================
+ Hits 50737 51115 +378
- Misses 37993 38300 +307
- Partials 3812 3843 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gastonponti
approved these changes
Jan 18, 2023
Closed
Good point, created a tracking issue and mentioned it in the description. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading some dependencies - see #1927
Ported ethereum/go-ethereum#24533 and made some extra changes to make things work.
Also this caused problems with the ios build, which was therefor disabled. This is tracked in #2000.
Other changes
Some changes ported from ethereum/go-ethereum#24533 might not have been absolutely necessary (ex. fixing a typo).
Tested
Existing tests
Related issues
Backwards compatibility
According to #24533, the changes are perfectly compatible and affect only non-cgo builds anyway. Looks like celo-blockchain can't build without cgo yet, so this is definitely not going to be an issue.