Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to restart pool on checkout_timeout error. #704

Merged
merged 3 commits into from Jul 20, 2022

Conversation

rkachowski
Copy link

@rkachowski rkachowski commented Jul 20, 2022

Description

There has been a spike in checkout_timeout errors since the mainnet stall - https://cloudlogging.app.goo.gl/Jnk5oDzFiee9nrqYA . According to edgurgel/httpoison#414 it seems that an entire http connection pool can be affected by timeout errors when the pool size is suitably large.

This PR includes the suggested fix to stop the hackney connection pool when this error is encountered.

Testing

  • ran locally against staging archive node and asserted that http connection to archive nodes was running successfully

Unclear how to test a situation where checkout_timeout is triggered directly, but we will rollback if affected

@github-actions
Copy link

github-actions bot commented Jul 20, 2022

Unit Test Results

       4 files  ±0     326 suites  ±0   2m 58s ⏱️ -7s
2 250 tests ±0  2 205 ✔️ ±0  45 💤 ±0  0 ±0 
2 281 runs  ±0  2 236 ✔️ ±0  45 💤 ±0  0 ±0 

Results for commit 9620610. ± Comparison against base commit b298c91.

♻️ This comment has been updated with latest results.

@shazarre shazarre marked this pull request as ready for review July 20, 2022 11:46
@shazarre shazarre requested a review from a team July 20, 2022 11:46
@rkachowski rkachowski merged commit 99e68e6 into master Jul 20, 2022
@rkachowski rkachowski deleted the bugfix/http_connection_pool branch July 20, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants