refactor(service/header): extract store initialization from Syncer #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
added a commit
that referenced
this pull request
Feb 12, 2022
Wondertan
added a commit
that referenced
this pull request
Feb 12, 2022
Wondertan
force-pushed
the
hlib/store-init
branch
from
f41b312
to
591f6b6
Compare
|
Yes and it is very minor, but you can review the PR anyway. I am going to resolve the conflict here and in other PRs altogether with any other rebase conflicts that might appear after applying review feedback. |
renaynay
reviewed
Feb 14, 2022
Wondertan
added a commit
that referenced
this pull request
Feb 15, 2022
Wondertan
force-pushed
the
hlib/store-init
branch
from
f60c198
to
323539a
Compare
Wondertan
added a commit
that referenced
this pull request
Feb 15, 2022
liamsi
reviewed
Feb 15, 2022
…g to recent changes
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
Wondertan
force-pushed
the
hlib/store-init
branch
from
d4e542e
to
40e7859
Compare
liamsi
reviewed
Feb 15, 2022
Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
|
Added closing issue |
liamsi
approved these changes
Feb 15, 2022
renaynay
approved these changes
Feb 15, 2022
|
Right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Syncer managed Store initialization, which means putting initial/genesis head to the Store, so the Node can sync on top. It's definitely not Syncer's responsibility to manage this and this was causing me troubles while I worked on other stuff, so I decided to extract that. As result, we have a more coherent and transparent initialization code.
Based on #428
Closes: #447
Review commit by commit