Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(blob/service)!: return empty values in case blobs were not found #3223

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

misc(blob/service)!: return empty values in case blobs were not found #3223

wants to merge 6 commits into from

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Mar 1, 2024

Resolves #3192

@vgonkivs vgonkivs added kind:misc Attached to miscellaneous PRs area:blob labels Mar 1, 2024
@vgonkivs vgonkivs self-assigned this Mar 1, 2024
ramin
ramin previously approved these changes Mar 1, 2024
View reviewed changes
Wondertan
Wondertan previously approved these changes Mar 1, 2024
View reviewed changes
@Wondertan
Copy link
Member

This is technically API breaking as someone could depend on the error, so we should mark it as so

@vgonkivs vgonkivs changed the title misc(blob/service): allow empty results in get all misc(blob/service)!: allow empty results in get all Mar 1, 2024
@vgonkivs vgonkivs added the kind:break! Attached to breaking PRs label Mar 1, 2024
walldiss
walldiss previously approved these changes Mar 4, 2024
View reviewed changes
@vgonkivs vgonkivs requested a review from jcstein March 4, 2024 10:58
@vgonkivs vgonkivs dismissed stale reviews from Wondertan, walldiss, and ramin via b88b3d3 March 7, 2024 12:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024 •
edited

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.57%. Comparing base (2469e7a) to head (b2990b8).
Report is 72 commits behind head on main.

Files Patch % Lines
blob/service.go 76.92% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   44.83%   44.57%   -0.27%     
==========================================
  Files         265      272       +7     
  Lines       14620    15276     +656     
==========================================
+ Hits         6555     6809     +254     
- Misses       7313     7677     +364     
- Partials      752      790      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs changed the title misc(blob/service)!: allow empty results in get all misc(blob/service): allow empty results in get all Mar 7, 2024
@vgonkivs vgonkivs removed the kind:break! Attached to breaking PRs label Mar 7, 2024
@jcstein
Copy link
Member

jcstein commented Mar 7, 2024 •
edited

This is technically API breaking as someone could depend on the error, so we should mark it as so

Isn't this breaking? why were tags and ! removed?

@vgonkivs
Copy link
Member Author

vgonkivs commented Mar 7, 2024

Reworked to non-breaking.

@jcstein
Copy link
Member

jcstein commented Mar 7, 2024

makes sense, thanks! and in this feature, if there are no blobs, empty vector is returned? is there anything else that changes from a user perspective?

ramin
ramin previously approved these changes Mar 8, 2024
View reviewed changes
@jcstein jcstein mentioned this pull request Mar 8, 2024
Open
@vgonkivs vgonkivs changed the title misc(blob/service)!: return single ErrNotFound in GetAll misc(blob/service)!: return empty values in case blobs were not found May 10, 2024
walldiss
walldiss reviewed May 10, 2024
View reviewed changes
blob/service.go Outdated Show resolved Hide resolved
blob/service.go Show resolved Hide resolved
@vgonkivs vgonkivs requested a review from walldiss May 13, 2024 10:37
renaynay
renaynay reviewed May 13, 2024
View reviewed changes
blob/service_test.go Outdated Show resolved Hide resolved
blob/service_test.go Outdated Show resolved Hide resolved
blob/service.go Outdated Show resolved Hide resolved
blob/service.go Show resolved Hide resolved
distractedm1nd
distractedm1nd previously approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Renes nits, the test you wrote is sufficient so I won't push anything

renaynay
renaynay previously approved these changes May 14, 2024
View reviewed changes
@renaynay renaynay added the v0.14.0 Intended for v0.14.0 release label May 14, 2024
distractedm1nd
distractedm1nd previously approved these changes May 15, 2024
View reviewed changes
@vgonkivs vgonkivs dismissed stale reviews from distractedm1nd and renaynay via b2990b8 May 16, 2024 13:26
renaynay
renaynay previously approved these changes May 16, 2024
View reviewed changes
@renaynay renaynay added v0.15.0 Intended for v0.15.0 release and removed v0.14.0 Intended for v0.14.0 release labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan left review comments

@distractedm1nd distractedm1nd distractedm1nd left review comments

@renaynay renaynay renaynay left review comments

@jcstein jcstein Awaiting requested review from jcstein

@ramin ramin Awaiting requested review from ramin ramin is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@vgonkivs vgonkivs

Labels
area:blob kind:break! Attached to breaking PRs kind:misc Attached to miscellaneous PRs v0.15.0 Intended for v0.15.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: blob_get_all could return empty Vec on "blob not found"
8 participants
@vgonkivs @Wondertan @codecov-commenter @jcstein @ramin @walldiss @distractedm1nd @renaynay