Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blobstream API should be moved to node #3361

Open
Tracked by #3335
liamsi opened this issue May 2, 2024 · 2 comments
Open
Tracked by #3335

Blobstream API should be moved to node #3361

liamsi opened this issue May 2, 2024 · 2 comments
Assignees
@rach-id
Labels
area:api Related to celestia-node API external Issues created by non node team members

Comments

@liamsi
Copy link
Member

liamsi commented May 2, 2024 •
edited

Proofs for Blobstream (DataRootInclusionProof and ProveShare endpoints on core) are not accessible through node API, so currently all integrations with Blobstream require one to have two endpoints, and two APIs.

related: celestiaorg/celestia-core#1306
@liamsi liamsi mentioned this issue May 2, 2024
Open
11 tasks
@github-actions github-actions bot added needs:triage external Issues created by non node team members labels May 2, 2024
@rach-id rach-id self-assigned this May 2, 2024
@Wondertan
Copy link
Member

Wondertan commented May 2, 2024 •
edited

We discussed this with @rach-id and we decided to implement Blobstream APIs over nodes API. This is the first step to accelerate development by not blocking on node's review process and practises. But, we also agreed to later merge it to node as a module.

@ramin ramin added area:api Related to celestia-node API and removed needs:triage labels May 6, 2024
@renaynay renaynay added v0.15.0 Intended for v0.15.0 release and removed v0.15.0 Intended for v0.15.0 release labels May 9, 2024
@rach-id rach-id mentioned this issue May 23, 2024
Open
@rach-id
Copy link
Member

rach-id commented Jun 2, 2024

Referencing this PR here: celestiaorg/blobstream-node-api#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
area:api Related to celestia-node API external Issues created by non node team members
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ramin @liamsi @Wondertan @rach-id @renaynay