You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue collects smaller quirks with the current API/docs/CLI in one place. I will list them here and break them out into their own issues where it makes sense:
CLI: when looking at the for usage returned by --help encoding related guidance is often missing, eg. celestia blob get [height] [namespace] [commitment] [flags] should state which format the inputs are expected in (hex? base64?). The CLI help should be self-contained; currently one needs to e.g. look here to know how to use this
CLI: namespaces are submitted as hex but returned base64 encoded (which is very confusing); example:
CLI/API: the node daemon gets started with only one account and one can only submit PFBs from that single account; this does not reflect how people interact with chains using different wallets for different purposes (applies to e.g. celestia blob submit and a bunch of state related commands / rpcs) [Feature Request]: Multiple celestia accounts can submit blobs via 1 DA Node #3295
I would like to add a couple of improvement ideas for reliable blob submission which is a blocker for rollup liveness:
"rpc error: code = Unknown desc = timed out waiting for tx to be included in a block" error is returned frequently possibly due to 1) mempool congestion 2) big blobs 3) too small timeout_broadcast_tx_commit
": tx already in mempool" always happens immediately after the above error and requires waiting out until the tx drops from the mempool
": incorrect account sequence" occasionally happens in place of the above error but also requires waiting out until the tx drops from the mempool
rpc error: code = Unknown desc = error on broadcastTxCommit: tx size is too big: 1962442, max: 1962441 happens when submitting big blobs due to padding shares even though the supposed limit is 1974272 so this breaks the contract with node.
rpc error: code = Unknown desc = error on broadcastTxCommit: tx too large occasionally big blobs return this in place of the above. I see that there's also Tx too large. Max size is %d, but got %d in the code.
Since there is no unique error code for these errors, we're currently grepping the string for these error strings which is not ideal.
It would be good to have a standardised error list and unique error codes and if possible, a error severity, and hint to allow clients to retry gracefully.
This issue collects smaller quirks with the current API/docs/CLI in one place. I will list them here and break them out into their own issues where it makes sense:
celestia-node/blob/service.go
Line 113 in f2b664f
--help
encoding related guidance is often missing, eg.celestia blob get [height] [namespace] [commitment] [flags]
should state which format the inputs are expected in (hex? base64?). The CLI help should be self-contained; currently one needs to e.g. look here to know how to use thiscelestia blob submit
and a bunch of state related commands / rpcs) [Feature Request]: Multiple celestia accounts can submit blobs via 1 DA Node #3295state submit-tx
#3345State.SubmitPayForBlob
vsBlob.Submit
: both methods are too similar and it's unclear when to use which (related: feat!(state/core_accessor): add SubmitPayForBlobWithOptions endpoint #3349 (comment))The text was updated successfully, but these errors were encountered: