feat: use a dynamic timeout commit modelled on the size of the block #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
May 23, 2024
| blockSizeBytes = maxBlockSize | ||
| } | ||
|
|
||
| timeoutCommit := cfg.TimeoutCommit - (time.Duration(blockSizeBytes) * perByteDelay) |
There was a problem hiding this comment.
what would be the best of determining this value? I guess adjusting on mocha?
would you describe the upside being simplicity and the downside being that changes to the network require re-calibrating this value?
There was a problem hiding this comment.
Yes, this function should be determined empirically by running 100 node networks with varying block sizes from 0MB to 8MB and modelling that into a function.
would you describe the upside being simplicity and the downside being that changes to the network require re-calibrating this value?
Yes it's a good simple temporary solution. If we go down the road of either compact blocks or proposer based timestamps. Those solutions can replace this current one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to show a quick way for implementing a dynamic timeout commit aimed at achieving more consistent block times. The approach is to model how the size of the block effects commit speed. This example PR uses a 8MB block as the upper bound which would reduce the timeout commit propotionally by up to 4 seconds. We obviously need to model what linear formula best fits the celestia network.