fix: Inaccurate Bucket Intervals for block_interval_seconds Metric #1307 #1308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix sets appropriate histogram buckets for the
celestia_consensus_block_interval_seconds_bucket
Prometheus metric.It addresses issue #1307
I also took a shot at improving the HELP description of the metric. I don't know if the metric records the time based on when the node sees the block or if it measures the time between blocks based on block timestamps. If it is the latter, I should adjust the HELP description to reflect that.
Here's a screenshot of what a Grafana graph looks like before/after updating this metric. Based on mochanet data.
Metrics before the change look like this;
Metrics after the fix look like this
PR checklist
I have not completed the checklist tasks. I can do these tomorrow where relevant
.changelog
(we useunclog to manage our changelog)
docs/
orspec/
) and code comments