feat: MConnection prioritizes received messages based on their channel ID priority #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
reviewed
Feb 14, 2024
…m around different routines
staheri14
force-pushed
the
sanaz/asyn-onreaceive
branch
from
03782fa
to
6fc3cee
Compare
staheri14
commented
Feb 16, 2024
p2p/conn/connection.go
Outdated
| @@ -869,7 +984,10 @@ func (ch *Channel) recvPacketMsg(packet tmp2p.PacketMsg) ([]byte, error) { | |||
| // suggests this could be a memory leak, but we might as well keep the memory for the channel until it closes, | |||
| // at which point the recving slice stops being used and should be garbage collected | |||
| ch.recving = ch.recving[:0] // make([]byte, 0, ch.desc.RecvBufferCapacity) | |||
| return msgBytes, nil | |||
|
|
|||
| msgCopy := make([]byte, len(msgBytes)) | |||
There was a problem hiding this comment.
[To reviewers] Without creating a new copy, the original output of this function msgBytes and the ch.recving slice would reference the same memory address. Consequently, if msgBytes is passed to another goroutine, it can lead to a race condition [and it does]. Therefore, it's necessary to create a fresh copy to prevent this issue.
staheri14
changed the title
|
The |
staheri14
requested review from
evan-forbes,
cmwaters,
rach-id,
ninabarbakadze and
rootulp
as code owners
|
This PR is ready for review. I am currently waiting for the results from testground to confirm our plan to merge this new logic. Once confirmed, I will mark it as ready for review. In the meantime, please feel free to leave any comments or feedback you may have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1192