Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cosmos/keyring #548

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Commits on Jul 14, 2022

  1. Remove cosmos/keyring

    cosmos/keyring hasn't pulled upstream changes from 99designs/keyring yet
    and the latest release of 99designs/keyring (1.2.1) appears to contain
    a fix for MacOS warnings: 99designs/keyring#107
    
    Links
    - https://github.com/cosmos/keyring/tags
    - https://github.com/99designs/keyring/releases/tag/v1.2.1
    
    `make test` passes after this change and it looks like other Cosmos
    chains don't need this replace:
    - https://github.com/osmosis-labs/osmosis/blob/main/go.mod#L274-L285=
    - https://github.com/CosmosContracts/juno/blob/main/go.mod#L178-L182=
    
    Does anyone know if it's still necessary? I couldn't find the justification in
    celestiaorg#127 which added it.
    rootulp committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    aa6d0c0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    798d4a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Configuration menu
    Copy the full SHA
    0ffea2d View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Configuration menu
    Copy the full SHA
    dbc64f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Configuration menu
    Copy the full SHA
    0827854 View commit details
    Browse the repository at this point in the history