Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox.ini for lint #1700

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update tox.ini for lint #1700

wants to merge 1 commit into from

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Apr 18, 2023

No description provided.

@sparrowt sparrowt mentioned this pull request Apr 19, 2023
Closed
@sparrowt
Copy link
Contributor

Looks like the problem now is pydocstyle==1.1.1 is pretty old (2016) and the deprecated way it does from collections import Set finally stopped working in python 3.10

pydocstyle==6.2.0 lists 'support for python 3.10' in the release notes although the PR suggests this is more about running pydocstyle's own CI on python 3.10 so if there are issues jumping straight to pydocstyle 6.x then an intermediate version might work fine.

@auvipy
Copy link
Member Author

auvipy commented Apr 19, 2023

yeah we should align it with celery version

@sparrowt
Copy link
Contributor

Also looks like mypy is left behind trying to run on 3.8 e.g. that was already failing on this run https://github.com/celery/kombu/actions/runs/4398408364/jobs/7702301475 before pr 1663 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auvipy @sparrowt