Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix atomic transaction not routing to the the correct DB in DatabaseBackend.on_chord_part_return transaction.atomic #427

Merged
merged 6 commits into from May 4, 2024
Merged

Fix atomic transaction not routing to the the correct DB in DatabaseBackend.on_chord_part_return transaction.atomic #427

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e74e9a4
using ChordCounter.objects.db in DatabaseBackend.on_chord_part_return…
gianbot Apr 5, 2024
c8752df
WIP testing on chord part return with multiple databases
dvdria Apr 24, 2024
17f9c2e
WIP testing on chord part return with multiple databases pre-committed
dvdria Apr 24, 2024
76d2d1b
Completed testing on chord part return with multiple databases
dvdria Apr 24, 2024
223b8de
Changed tests and transaction atomic using according to pull request …
dvdria Apr 30, 2024
ec32f76
Removed ports from settings
dvdria Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion django_celery_results/backends/database.py
View file
Open in desktop
Expand Up @@ -246,7 +246,7 @@ def on_chord_part_return(self, request, state, result, **kwargs):
if not gid or not tid:
return
call_callback = False
with transaction.atomic():
with transaction.atomic(using=ChordCounter.objects.db):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseManager.objects.db returns the django.db.router.db_for_read() which in your situation works since it returns the same db alias as the db_for_write().

https://github.com/django/django/blob/2be37b253341cfd1f1363c533e6f896230f047a7/django/db/models/manager.py#L143

Consider using django.db.router.db_for_write(ChordCounter) instead as we will be updating the ChordCounter.count value within the transaction.

# We need to know if `count` hits 0.
# wrap the update in a transaction
# with a `select_for_update` lock to prevent race conditions.
Expand Down