New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add django 5.0 to CI/test matrix and project classifiers #425
Conversation
Ooops, didn’t mean to make that part of this change.
.github/workflows/test.yaml
Outdated
exclude: | ||
- python-version: "3.11" | ||
django: 32 | ||
- python-version: 3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the pypy3.9 also be added to the exclusion list for django 5?
https://docs.djangoproject.com/en/5.0/releases/5.0/#python-compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BradleyKirton Nice catch; had 3.9 in exclusions but missed pypy3.9. Added now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the build failures
@auvipy Build should be passing now. The primary issue was pytest 8 was failing (all prior builds were running against pytest 7 and the pytest 8 release in Jan 2024 had breaking changes). I had to apply a <8 version constraint and the build would pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a maintainer but may I also suggest to update the classifiers:
django-celery-results/setup.py
Lines 44 to 48 in cb94489
Framework :: Django | |
Framework :: Django :: 3.2 | |
Framework :: Django :: 4.0 | |
Framework :: Django :: 4.1 | |
Framework :: Django :: 4.2 |
Opened a PR against your fork to add it https://github.com/charlesobrien/django-celery-results/pull/1 |
Add Django 5.0 to classifiers
Thanks; I've merged that! |
@auvipy Following up. Anything else needed for merge? |
Adding Django 5.0 to CI/test matrix and bumping some other Django minor versions