Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add django 5.0 to CI/test matrix and project classifiers #425

Merged
merged 8 commits into from Mar 29, 2024

Conversation

charlesobrien
Copy link
Contributor

Adding Django 5.0 to CI/test matrix and bumping some other Django minor versions

@charlesobrien charlesobrien mentioned this pull request Mar 5, 2024
exclude:
- python-version: "3.11"
django: 32
- python-version: 3.8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the pypy3.9 also be added to the exclusion list for django 5?

https://docs.djangoproject.com/en/5.0/releases/5.0/#python-compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradleyKirton Nice catch; had 3.9 in exclusions but missed pypy3.9. Added now!

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the build failures

@charlesobrien
Copy link
Contributor Author

please check the build failures

@auvipy Build should be passing now. The primary issue was pytest 8 was failing (all prior builds were running against pytest 7 and the pytest 8 release in Jan 2024 had breaking changes). I had to apply a <8 version constraint and the build would pass.

Copy link
Contributor

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer but may I also suggest to update the classifiers:

Framework :: Django
Framework :: Django :: 3.2
Framework :: Django :: 4.0
Framework :: Django :: 4.1
Framework :: Django :: 4.2

@browniebroke
Copy link
Contributor

I'm not a maintainer but may I also suggest to update the classifiers:

Framework :: Django
Framework :: Django :: 3.2
Framework :: Django :: 4.0
Framework :: Django :: 4.1
Framework :: Django :: 4.2

Opened a PR against your fork to add it https://github.com/charlesobrien/django-celery-results/pull/1

Add Django 5.0 to classifiers
@charlesobrien charlesobrien changed the title add django 5.0 to CI/test matrix add django 5.0 to CI/test matrix and project classifiers Mar 22, 2024
@charlesobrien
Copy link
Contributor Author

I'm not a maintainer but may I also suggest to update the classifiers:

Framework :: Django
Framework :: Django :: 3.2
Framework :: Django :: 4.0
Framework :: Django :: 4.1
Framework :: Django :: 4.2

Opened a PR against your fork to add it charlesobrien#1

Thanks; I've merged that!

@charlesobrien
Copy link
Contributor Author

@auvipy Following up. Anything else needed for merge?

@auvipy auvipy merged commit 23265e6 into celery:main Mar 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants