Revert "feat: raw delete expired instead of Queryset.delete (#235)"
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Apr 24, 2023
The fix for the CI failure is in #382 (at least partially). The full fix can be found in the latest commit of this PR. |
hansegucker
force-pushed
the
revert-raw-delete
branch
from
50ac661
to
27d8adb
Compare
|
Please rerun CI with current changes. |
|
we have only one test to fix |
auvipy
approved these changes
Apr 28, 2023
|
It would be perfect if we can get a new release with this fix. |
|
ping me next week |
|
@auvipy ping |
|
Ping again tomorrow please! |
|
@auvipy ping again |
|
@auvipy ping, ping ;-) |
|
sorry forgot about it with other priorities! |
|
released! |
|
Thank you very much! |
|
I am sorry for the delay. there are lots of other things to look after so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 7c7cb67 as recommended in #235 (comment). This also fixes #383.