Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix atomic transaction not routing to the the correct DB #324
Fix atomic transaction not routing to the the correct DB #324
Changes from 2 commits
62497f9
2c971d7
5f7a91a
50df557
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain this part a bit more please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will try to run the method
delete_expired
from the Custom ManagerResultManager
where the bug occurs.The issue is that if the manager was directed to use a db other than the "default" db, the method
delete_expired
would run the operation on the "default" anyways. Since the function does not return anything and is a delete operation I can not use assertMy method of testing is the below: (let me know if there is a better way)
I specify the allowed db to test on as "secondary" only. If the test tries to use the "default" db it will throw error:
https://github.com/nofalx/django-celery-results/blob/fix-323/t/unit/test_models.py#L231:L232
I specify the
TaskResult
and theGroupResult
manager which extendResultManager
to use "secondary" db using.db_manager("secondary")
.https://github.com/nofalx/django-celery-results/blob/fix-323/t/unit/test_models.py#L235:L240
Before the fixes this test would fail as
transaction.atomic()
would try to use the "default" db. After the fix the method doesnt use "default" db anymore and the test pass.