Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix properties default value #281

Merged
merged 2 commits into from Jan 26, 2022
Merged

Fix properties default value #281

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47604d0
Fix properties default value
KOliver94 Jan 9, 2022
14ab2bf
Add default value to getattr to avoid exception
KOliver94 Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion django_celery_results/backends/database.py
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ def _store_result(
)

task_name = getattr(request, 'task', None)
properties = getattr(request, 'properties', {})
properties = getattr(request, 'properties') or {}
periodic_task_name = properties.get('periodic_task_name', None)
worker = getattr(request, 'hostname', None)

Expand Down
2 changes: 1 addition & 1 deletion t/unit/backends/test_database.py
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ def _create_request(self, task_id, name, args, kwargs,
)
if task_protocol == 1:
body, headers, _, _ = hybrid_to_proto2(msg, msg.body)
properties = {}
properties = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about None or {}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this field to reflect the problem and create a more edge-case like scenario when the properties field are present but with None value.

sent_event = {}
else:
headers, properties, body, sent_event = msg
Expand Down