don't kill if pid same as file (#8997) #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8998 +/- ##
=======================================
Coverage 77.80% 77.81%
=======================================
Files 150 150
Lines 18686 18688 +2
Branches 3193 3194 +1
=======================================
+ Hits 14539 14542 +3
Misses 3854 3854
+ Partials 293 292 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
requested changes
May 2, 2024
auvipy
requested changes
May 4, 2024
auvipy
approved these changes
May 5, 2024
lewijw
added a commit
to lewijw/celery
that referenced
this pull request
May 6, 2024
The pid file needs to be deleted.
auvipy
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
When celery runs in a pod in k8s, it runs as PID 1. If it crashes, k8s restarts the process but since the pid file has a 1 in it, it kills itself. With this change, if the pid in the file is the same as the pid of the process, it will not kill the process.