fix: bump eventlet to support more python version

[florianvazelle]

Hi 👋

I submit a PR to bump the extra eventlet requirement.

It's seems that the python_version<"3.10" condition where added in #6807, with the commit 914c6cd, 3 years ago.

The message of the commit was "Currently, eventlet is not supported by 3.10.".

So now, the eventlet package support python from 3.7 to 3.12 (ref: https://github.com/eventlet/eventlet/tree/v0.34.0?tab=readme-ov-file#supported-python-versions).

[florianvazelle]

It's seems that:

• t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_mongodb_dnspython2_pymongo4_seedlist failed on python 3.8, 3.9 and 3.10,
• t/unit/concurrency/test_eventlet.py::test_aaa_eventlet_patch::test_aaa_blockdetecet failed on python 3.11 and 3.12,

I would like some input on these tests 😅

[auvipy]

New usages of eventlet are now heavily discouraged!

we might need to consider deprecate it's support

[Nusnus]

It's seems that:

• t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_mongodb_dnspython2_pymongo4_seedlist failed on python 3.8, 3.9 and 3.10,
• t/unit/concurrency/test_eventlet.py::test_aaa_eventlet_patch::test_aaa_blockdetecet failed on python 3.11 and 3.12,

I would like some input on these tests 😅

I already fixed that on main - rebasing this PR to get it away :)

[Nusnus]

New usages of eventlet are now heavily discouraged!

we might need to consider deprecate it's support

Until we give it some focus, I think it does makes sense to at least allow the bump, no @auvipy ?

[auvipy]

we should bump for sure for now

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (078f80f) to head (1cfca86).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8979   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files         150      150           
  Lines       18686    18686           
  Branches     3193     3193           
=======================================
  Hits        14540    14540           
  Misses       3854     3854           
  Partials      292      292           

Flag	Coverage Δ
unittests	77.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[auvipy]

there are still some failures

[Nusnus]

there are still some failures

Yeah I notice this happens on main, something new I guess :/

[Nusnus]

there are still some failures

Yeah I notice this happens on main, something new I guess :/

Working on a fix #8999

[Nusnus]

there are still some failures

Yeah I notice this happens on main, something new I guess :/

Working on a fix #8999

I’ll rebase all of the failing PRs after I get main to 100% pass @auvipy

[Nusnus]

It should be working now 🤞

[Nusnus]

2024-05-02T22:01:49.3410797Z FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_mongodb_dnspython2_pymongo4_seedlist
2024-05-02T22:01:49.3411879Z FAILED t/unit/concurrency/test_eventlet.py::test_aaa_eventlet_patch::test_aaa_blockdetecet

Very weird…

@florianvazelle can you double check me this branch is rebased on latest main?

[Nusnus]

2024-05-02T22:01:49.3410797Z FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_mongodb_dnspython2_pymongo4_seedlist
2024-05-02T22:01:49.3411879Z FAILED t/unit/concurrency/test_eventlet.py::test_aaa_eventlet_patch::test_aaa_blockdetecet

Very weird…

@florianvazelle can you double check me this branch is rebased on latest main?

Very interesting they released another version since I was trying to figure out what's going on:
#9000

Let's see if it is now stable..

[Nusnus]

I really don’t understand what’s going on…
Long shot - changed from 0.34 to 0.36

[Nusnus]

https://github.com/eventlet/eventlet/releases/tag/0.36.1

[Nusnus]

Nope

2024-05-03T08:31:38.4655135Z FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_mongodb_dnspython2_pymongo4_seedlist
2024-05-03T08:31:38.4655989Z FAILED t/unit/concurrency/test_eventlet.py::test_aaa_eventlet_patch::test_aaa_blockdetecet

[Nusnus]

Giving up isn’t really my style, but this is becoming an overkill.
Added back the < Py310 restriction but updated to 0.36.1 - I now care only to see if it even works :/

[Nusnus]

Well, I’d say then "Python 3.7-3.12 are currently supported.” from their docs is probably incorrect, or not fully correct.

Being super deprecated, I’d recommend discarding this PR as it doesn’t change anything really (with my latest modifications).

@auvipy @florianvazelle

[florianvazelle]

Well, I’d say then "Python 3.7-3.12 are currently supported.” from their docs is probably incorrect, or not fully correct.

Being super deprecated, I’d recommend discarding this PR as it doesn’t change anything really (with my latest modifications).

@auvipy @florianvazelle

Ok, no problem for me, eventlet seems not to work very well and is unmaintained.
Do I need to open an issue to deprecated/removed the use of eventlet with celery ?

[Nusnus]

Well, I’d say then "Python 3.7-3.12 are currently supported.” from their docs is probably incorrect, or not fully correct.
Being super deprecated, I’d recommend discarding this PR as it doesn’t change anything really (with my latest modifications).
@auvipy @florianvazelle

Ok, no problem for me, eventlet seems not to work very well and is unmaintained. Do I need to open an issue to deprecated/removed the use of eventlet with celery ?

It’s fine, thanks.
We’ll handle it once we can allocate some focus into improving it, for now we can just move on :)