Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disable_sync_subtasks from the EagerResult.get method. #8070

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YPCrumble
Copy link

Fixes #6072.

@auvipy this draft is what I was suggesting for EagerResult. Because the task is run "locally" it means that the issues with synchronous subtasks should not apply. For instance, the docs suggest that this "may even cause a deadlock if the worker pool is exhausted", but because an EagerResult created by apply is not sent to the worker pool this isn't possible.

I suppose there's a chance that EagerResult could potentially be created somewhere other than the apply function, but I couldn't find an instance of this in the code to date. As long as EagerResult is never a result of a task generated by the worker pool I think this PR makes sense, because there is no chance of deadlock.

If this PR makes sense I would be happy to update the docs and warnings, as well as improve the docstrings.

Thanks again for maintaining Celery, and I'd love to hear your feedback on this PR!

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demonstrating a failing test case, along with the proposed removal of disable_sync_subtasks check is needed to properly understand the scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling get() on a synchronous chain result triggers E_WOULDBLOCK
2 participants