Remove disable_sync_subtasks from the EagerResult.get method. #8070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6072.
@auvipy this draft is what I was suggesting for
EagerResult
. Because the task is run "locally" it means that the issues with synchronous subtasks should not apply. For instance, the docs suggest that this "may even cause a deadlock if the worker pool is exhausted", but because anEagerResult
created byapply
is not sent to the worker pool this isn't possible.I suppose there's a chance that
EagerResult
could potentially be created somewhere other than theapply
function, but I couldn't find an instance of this in the code to date. As long asEagerResult
is never a result of a task generated by the worker pool I think this PR makes sense, because there is no chance of deadlock.If this PR makes sense I would be happy to update the docs and warnings, as well as improve the docstrings.
Thanks again for maintaining Celery, and I'd love to hear your feedback on this PR!
Note: Before submitting this pull request, please review our contributing
guidelines.
Description