Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix pypy3 CI #6417

Merged
merged 1 commit into from Oct 29, 2020
Merged

Conversation

maybe-sybr
Copy link
Contributor

This changeset fixes the TOXENV for pypy3 unit tests in travis and adds
rabbitmq integration tests against pypy3 as well like we do for Python 3.9.

@maybe-sybr
Copy link
Contributor Author

I've put in a speculative integration test against a rabbitmq backend to see if it works. It's not really necessary to fix #6409 but can't hurt if it works (except chew CI time, so happy for it to be vetoed based on that as well).

@maybe-sybr maybe-sybr changed the title Maybe/ci correct pypy3 toxenv ci: Fix pypy3 CI Oct 15, 2020
@maybe-sybr
Copy link
Contributor Author

Looks like the unit tests were fine but one of my integration tests from #6354 timed out. Probably needs a bit of digging to work out if it's actually broken or just flaky on pypy3 for some reason. I don't have the time to dig into it right now so I'd be fine with stripping the integration test job out of this changeset and just fixing the unit tests for now. LMK what you'd like to do and I can amend the branch.

@auvipy auvipy self-requested a review October 17, 2020 04:09
@maybe-sybr
Copy link
Contributor Author

maybe-sybr commented Oct 29, 2020

@auvipy I've stripped the commit which added the breaking integration test for now. I can look at that at some later point, for now getting pypy3 unit tests running is a good start.

https://github.com/maybe-sybr/celery/tree/maybe/ci-pypy3-integration if anyone is interested in following up/stealing that branch from me.

@auvipy auvipy merged commit 678e422 into celery:master Oct 29, 2020
@auvipy auvipy added this to the 5.0.2 milestone Oct 29, 2020
@maybe-sybr maybe-sybr deleted the maybe/ci-correct-pypy3-toxenv branch October 29, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants