Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deeply deserialize groups #6342

Merged
merged 4 commits into from Oct 17, 2020
Merged

Deeply deserialize groups #6342

merged 4 commits into from Oct 17, 2020

Commits on Oct 15, 2020

  1. test: Improve chord body group index freezing test 

    Add more elements to the body so we can verify that the `group_index`
counts up from 0 as expected. This change adds the `pytest-subtests`
package as a test dependency so we can define partially independent
subtests within test functions.
    @maybe-sybr
    maybe-sybr committed Oct 15, 2020
    Copy the full SHA
    c3882e2 View commit details
    Browse the repository at this point in the history

  2. test: Use all() for subtask checks in canvas tests 

    When we expect all of the tasks in some iterable to meet a conditional,
we should make that clear by using `all(condition for ...)`.
    @maybe-sybr
    maybe-sybr committed Oct 15, 2020
    Copy the full SHA
    d5cccb3 View commit details
    Browse the repository at this point in the history

  3. test: Add more tests for from_dict() variants 

    Notably, this exposed the bug tracked in celery#6341 where groups are not
deeply deserialized by `group.from_dict()`.
    @maybe-sybr
    maybe-sybr committed Oct 15, 2020
    Copy the full SHA
    7034adf View commit details
    Browse the repository at this point in the history

  4. fix: Ensure group tasks are deeply deserialised 

    Fixes celery#6341
    @maybe-sybr
    maybe-sybr committed Oct 15, 2020
    Copy the full SHA
    cd979e8 View commit details
    Browse the repository at this point in the history